Skip to content

[14] update ECR base image and upstream libs#15

Closed
chrisbc wants to merge 21 commits into
deploy-testfrom
chore/upgrade_ECR_image_to_python3.13
Closed

[14] update ECR base image and upstream libs#15
chrisbc wants to merge 21 commits into
deploy-testfrom
chore/upgrade_ECR_image_to_python3.13

Conversation

@chrisbc
Copy link
Copy Markdown
Member

@chrisbc chrisbc commented Aug 28, 2025

closes #14
closes #9

attempt to resolve build issues by updating to latest ECR using python 3.13

  • new ECR base image
  • add gcc++ compiler to image
  • temporarily using git ref for tohki-hazard-store lib to get python 3.13 support
  • fixed some tests
  • moved everything (tests, build, etc) to Python 3.13
  • upgraded some dev dependencies (flake8, black, twine) to make them work with Python 3.13
  • Docker: merged RUN steps and added tidying up to reduce docker image size from 2.83GB to 2.01GB. The base image that we pull in is only 0.76GB large, so there's potentially still a lot of room for improvement.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.62%. Comparing base (4518676) to head (5ca0e72).
⚠️ Report is 23 commits behind head on deploy-test.

Additional details and impacted files
@@             Coverage Diff              @@
##           deploy-test      #15   +/-   ##
============================================
  Coverage        90.62%   90.62%           
============================================
  Files               14       14           
  Lines              480      480           
  Branches            33       33           
============================================
  Hits               435      435           
  Misses              38       38           
  Partials             7        7           
Flag Coverage Δ
unittests 90.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@voj voj self-assigned this Sep 2, 2025
@voj voj changed the title update ECR base image and upstream libs [14] update ECR base image and upstream libs Sep 2, 2025
@voj voj requested a review from chrisdicaprio September 2, 2025 03:53
Comment thread pyproject.toml
poetry-plugin-export = "^1.9.0"
serverless-wsgi = "^3.0.5"
python-dotenv = "^1.1.0"
toshi-hazard-store = "^1.2.1"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably worth doing the release cycle to get rid of git ref before merging

@voj voj self-requested a review September 2, 2025 23:33
Copy link
Copy Markdown
Collaborator

@voj voj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since OpenQuake only supports up to 3.12, there is now #16 which fixes the build by going to 3.12, not requiring THS or nzshm-model to be changed at all.

Preserving this here for @chrisbc but should probably be closed.

@voj voj removed their assignment Sep 2, 2025
@chrisbc chrisbc mentioned this pull request Oct 20, 2025
chrisbc added a commit that referenced this pull request Oct 20, 2025
Merge deplo- test to main

- latest THS Chore/update to latest ths #8
- ECR deployment [14] update ECR base image and upstream libs #15
- yarn lock file Chore/17 yarn2 and node lock file #18
- serverless V4 migration Chore/20 serverless v4 migration #21
@chrisbc
Copy link
Copy Markdown
Member Author

chrisbc commented Nov 23, 2025

this was superceded by #16

@chrisbc chrisbc closed this Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Cannot build docker image Chore: use shared workflow for deployment

3 participants